PLAT-159: Migrate test_jobs #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ethho
commented
Dec 13, 2023
ethho
commented
- Changes from PLAT-156: Migrate test_fetch #1129
- Changes from PLAT-157: Migrate test_fetch_same #1130
- cp to tests
- nose2pytest test_jobs
- All but two test_jobs passing
- Clean jobs table in fixture
- Change from generator to list
- Tolerate error when cleaning up schema_any.jobs
- Format with black
Later tests in test_jobs would fail because SimpleSource contents generator exhausted, so the child tables' populate reserves no jobs due to no keys.
ethho
commented
Dec 13, 2023
| id : int # id | ||
| """ | ||
| contents = ((x,) for x in range(10)) | ||
| contents = [(x,) for x in range(10)] |
Contributor
Author
There was a problem hiding this comment.
Similar to #1129 (comment), this generator was exhausted by one test, causing failures for additional tests that required non-empty SimpleSource.contents.
A-Baji
approved these changes
Dec 13, 2023
| assert subjects | ||
| table_name = "fake_table" | ||
|
|
||
| key = subjects.fetch("KEY")[0] |
Member
There was a problem hiding this comment.
you can limit in these cases for better performance: subjects.fetch("KEY", limit=1)[0]
ethho
added a commit
to ethho/datajoint-python
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.