docs/spec #29
Merged
docs/spec #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
commented
Oct 10, 2025
| event_rate = (x - zero_level) / conversion_gain | ||
|
|
||
| zero_slope = 1.0 / (beta * math.sqrt(3.0 / 8.0)) | ||
| zero_slope = 1.0 / (beta * np.sqrt(3.0 / 8.0)) |
There was a problem hiding this comment.
Suggested change
| zero_slope = 1.0 / (beta * np.sqrt(3.0 / 8.0)) | |
| zero_slope = 1.0 / (beta * 0.612372) # 0.612372 approx (3.0 / 8.0) ** 0.5 |
There was a problem hiding this comment.
Yes, it's clearer since we aleady import numpy. I usually do ( )**0.5 to avoid extra imports.
There was a problem hiding this comment.
Importing numpy for something so simple is not my first choice but we need numpy for the casting logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a specification document for the anscombe-transform codec. Once this is complete, we can open a PR over at zarr-extensions that links to the docs page containing the spec.