Skip to content

Conversation

@davidhewitt
Copy link
Collaborator

Refactors the test to run more queries with JSON column types of Utf8, LargeUtf8 (both maybe dict encoded), plus Utf8View.

@davidhewitt davidhewitt requested a review from adriangb July 29, 2025 13:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.44%. Comparing base (65a8bdc) to head (2778b1c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   82.28%   82.44%   +0.15%     
==========================================
  Files          16       16              
  Lines        1253     1253              
  Branches     1253     1253              
==========================================
+ Hits         1031     1033       +2     
+ Misses        158      156       -2     
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidhewitt
Copy link
Collaborator Author

I bumped MSRV to 1.85.1 which is what datafusion 49 will require anyway.

@davidhewitt davidhewitt enabled auto-merge (squash) July 29, 2025 13:22
@davidhewitt davidhewitt merged commit 1e9358d into main Jul 29, 2025
7 checks passed
@davidhewitt davidhewitt deleted the dh/test-string-views branch July 29, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants