-
Notifications
You must be signed in to change notification settings - Fork 224
Ukrainian Locale Enhancements #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1704 +/- ##
=========================================
Coverage 92.32% 92.32%
- Complexity 3433 3434 +1
=========================================
Files 337 337
Lines 6779 6779
Branches 670 670
=========================================
Hits 6259 6259
- Misses 353 354 +1
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add/update the unit tests?
@kingthorin could you please provide some references or examples? I don’t see any tests for vehicle details or universities for other locales |
|
Yup, I'll dig it up in the morning. |
|
Have a look at toward the bottom of https://github.com/datafaker-net/datafaker/blob/main/src/test/java/net/datafaker/providers/base/VehicleTest.java there's some Canada and Ireland specific tests. Basically you just instantiate the faker with the locale in question and run your tests 👍 |
|
Looks like I messed up a bit while synchronizing my local branch with the main branch from the upstream repo, but all the changes are here anyway. I added the tests as requested, but I also made a few additional changes—please let me know if it's too much for one PR, just so I can keep that in mind for future ones. |
asolntsev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, something strange happened. :)
Try to rebase your branch on the latest origin/main branch.
Also, a minor thing: file "uk.yml" contains language-specific value, while "_UA.yml" contains country-specific value. So ,vehicle.fuel_types and vehicle.transmissions should be moved to "uk.yml".
…r UK and UZ university names
…s to the new VehicleLocaleTest class
|
@asolntsev done and done! |
|
@vicky-iv DataFaker 2.5.3 has been released. Thank you for your contributions! |
This pull request expands and improves the Ukrainian locale by adding more country-specific data:
Also normalized all generated vehicle license plates to uppercase for consistency.