Skip to content

Conversation

@vicky-iv
Copy link
Contributor

This pull request expands and improves the Ukrainian locale by adding more country-specific data:

  • Added Ukrainian universities
  • Vehicle data
  • Minor adjustments and formatting changes

Also normalized all generated vehicle license plates to uppercase for consistency.

@what-the-diff
Copy link

what-the-diff bot commented Oct 23, 2025

PR Summary

  • Enhanced License Plate Feature: The feature associated with generating vehicle license plate numbers has been improved. It now returns information in uppercase, making it more standardised and legible.

  • Enhanced Ukrainian Online Resources: Updates have been made to the Ukrainian resources used by our service. This includes improved formatting of Ukrainian addresses, an updated list of currency codes, and additional email domains and domain suffixes to provide a more comprehensive service to our users. We've also introduced exciting new information about vehicles, including regional abbreviations, license plate formats and specific vehicle details.

  • New Information on Ukrainian Universities: We’ve added a fresh list of Ukrainian universities. This new resource will enable our users to access details about reputable academic institutions located across the country.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (bf4482d) to head (dd44c91).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1704   +/-   ##
=========================================
  Coverage     92.32%   92.32%           
- Complexity     3433     3434    +1     
=========================================
  Files           337      337           
  Lines          6779     6779           
  Branches        670      670           
=========================================
  Hits           6259     6259           
- Misses          353      354    +1     
+ Partials        167      166    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 2.5.3 milestone Oct 23, 2025
Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add/update the unit tests?

@vicky-iv
Copy link
Contributor Author

Could you add/update the unit tests?

@kingthorin could you please provide some references or examples? I don’t see any tests for vehicle details or universities for other locales

@kingthorin
Copy link
Collaborator

Yup, I'll dig it up in the morning.

@kingthorin
Copy link
Collaborator

Have a look at toward the bottom of https://github.com/datafaker-net/datafaker/blob/main/src/test/java/net/datafaker/providers/base/VehicleTest.java there's some Canada and Ireland specific tests.

Basically you just instantiate the faker with the locale in question and run your tests 👍

@vicky-iv
Copy link
Contributor Author

Looks like I messed up a bit while synchronizing my local branch with the main branch from the upstream repo, but all the changes are here anyway.

I added the tests as requested, but I also made a few additional changes—please let me know if it's too much for one PR, just so I can keep that in mind for future ones.

Copy link
Collaborator

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, something strange happened. :)
Try to rebase your branch on the latest origin/main branch.

Also, a minor thing: file "uk.yml" contains language-specific value, while "_UA.yml" contains country-specific value. So ,vehicle.fuel_types and vehicle.transmissions should be moved to "uk.yml".

@vicky-iv
Copy link
Contributor Author

@asolntsev done and done!
I cleaned up a commit history. It probably wasn’t the best idea to mess with Git on a Friday evening 😁

@vicky-iv vicky-iv requested a review from asolntsev October 26, 2025 02:15
@asolntsev asolntsev merged commit 441b6fb into datafaker-net:main Oct 26, 2025
13 checks passed
@asolntsev asolntsev self-assigned this Oct 26, 2025
@asolntsev
Copy link
Collaborator

@vicky-iv Should we release 2.5.3, or you want to submit some more PRs?

@asolntsev
Copy link
Collaborator

@vicky-iv DataFaker 2.5.3 has been released. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants