Skip to content

Conversation

@hermansje
Copy link
Member

@hermansje hermansje commented Jan 14, 2020

Ticket

Link to ticket: https://datacamp.atlassian.net/browse/CX-1182

What has been done

How to test

  • Run the tests on top of the protowhat branch

@hermansje hermansje requested a review from vvnkr January 14, 2020 16:13
@hermansje hermansje self-assigned this Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #33 into master will decrease coverage by 0.36%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   99.04%   98.67%   -0.37%     
==========================================
  Files          15       16       +1     
  Lines         521      528       +7     
==========================================
+ Hits          516      521       +5     
- Misses          5        7       +2
Impacted Files Coverage Δ
sheetwhat/sct_syntax.py 0% <0%> (-100%) ⬇️
sheetwhat/checks/__init__.py 100% <100%> (ø) ⬆️
sheetwhat/sct_context.py 100% <100%> (ø)
sheetwhat/State.py 100% <100%> (ø) ⬆️
sheetwhat/checks/check_chart.py 100% <100%> (ø) ⬆️
sheetwhat/Test.py 98.61% <66.66%> (+1.38%) ⬆️
sheetwhat/test_exercise.py 96% <94.11%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f23d1...f5b83fe. Read the comment docs.

@MatzHilven MatzHilven force-pushed the jh/protowhat-refactor branch from 186ce72 to 0b131ae Compare August 20, 2025 09:17
@MatzHilven MatzHilven merged commit a014df6 into master Aug 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants