-
Notifications
You must be signed in to change notification settings - Fork 8
[CX-1180] feat: embed helpers #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 80.64% 81.42% +0.77%
==========================================
Files 16 16
Lines 811 845 +34
==========================================
+ Hits 654 688 +34
Misses 157 157
Continue to review full report at Codecov.
|
34bb5d4 to
57a0471
Compare
57a0471 to
5decf37
Compare
5decf37 to
2f62d61
Compare
2f62d61 to
4512dcc
Compare
4512dcc to
dc42d69
Compare
dc42d69 to
e8c0790
Compare
TimSangster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Currently, using one xwhat library in another one requires quite some glue code using internals of the SCT system.
embed_xwhatorget_embed_chain_constructorswould be the way to use this, we should probably only expose one way to do this.This PR adds some helpers that makes it easier and more future proof to do this.
TODO