Skip to content

Conversation

@hermansje
Copy link
Member

@hermansje hermansje commented Jul 29, 2019

Currently, using one xwhat library in another one requires quite some glue code using internals of the SCT system.

embed_xwhat or get_embed_chain_constructors would be the way to use this , we should probably only expose one way to do this.

This PR adds some helpers that makes it easier and more future proof to do this.

TODO

  • Decide on exposed helper.
  • Add tests (I first want to get feedback on the feature).
  • Add a usage example.

@hermansje hermansje requested review from TimSangster and vvnkr July 29, 2019 11:41
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #42 into master will increase coverage by 0.77%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   80.64%   81.42%   +0.77%     
==========================================
  Files          16       16              
  Lines         811      845      +34     
==========================================
+ Hits          654      688      +34     
  Misses        157      157
Impacted Files Coverage Δ
protowhat/utils.py 100% <100%> (ø) ⬆️
protowhat/sct_syntax.py 95.76% <100%> (+1.31%) ⬆️
protowhat/State.py 85.18% <80%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd743b4...e8c0790. Read the comment docs.

@hermansje hermansje force-pushed the jh/embed-helpers branch 5 times, most recently from 34bb5d4 to 57a0471 Compare July 31, 2019 12:28
@hermansje hermansje marked this pull request as ready for review January 14, 2020 13:01
@hermansje hermansje changed the title feat: embed helpers [CX-1180] feat: embed helpers Jan 14, 2020
@hermansje hermansje requested a review from vvnkr January 14, 2020 13:23
@hermansje hermansje self-assigned this Jan 14, 2020
Copy link
Contributor

@TimSangster TimSangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hermansje hermansje merged commit c1e621d into master Jan 27, 2020
@hermansje hermansje deleted the jh/embed-helpers branch January 27, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants