Skip to content

Conversation

someshkoli
Copy link
Contributor

@someshkoli someshkoli commented Sep 8, 2025

Hey, we have a use case where we wanted diff reports rather than them being written to io.Writer, wanted to know your thoughts on getting this in, also open to further suggestions if there are existing ways to achieve this. LMK

@yxxhero
Copy link
Collaborator

yxxhero commented Sep 8, 2025

@someshkoli what's your user case?

@someshkoli
Copy link
Contributor Author

@someshkoli what's your user case?

Hey, so we want per resource diff / delta so we can further work on that data and output in seprate ui (not cli)

@yxxhero
Copy link
Collaborator

yxxhero commented Sep 8, 2025

generateReport but this function not be exposed? @someshkoli and please sign off your commit.

@someshkoli
Copy link
Contributor Author

generateReport but this function not be exposed? @someshkoli and please sign off your commit.

its internal method, there's an exposed method which does return the report, yeah i'll fix the signature

@someshkoli someshkoli force-pushed the ft-diff-report branch 2 times, most recently from ea5d6a9 to 57de4fd Compare September 10, 2025 15:20
@someshkoli
Copy link
Contributor Author

@yxxhero ready for merge!

@yxxhero
Copy link
Collaborator

yxxhero commented Sep 11, 2025

@mumoshu ping

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @someshkoli!

@yxxhero yxxhero merged commit 538d19c into databus23:master Sep 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants