-
Notifications
You must be signed in to change notification settings - Fork 440
options changes only #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options changes only #124
Conversation
this works everywhere but travis! the partitions are re-ordered somehow methinks. leaving this for another time
Current coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come comment, schema, and charset are not included in CSVParsingOpts? I don't clearly see a benefit for this level of indirection yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the parser improves a ton of options are being added. it makes sense to organize them in containers for ease of use. imho, schema is a separate thing. i intended csvparsingopts to contain options that are passed to the csv parsing library. i can change the name if there is a better one you can think of
comment/charset can be here but there was a race between my commit and the one that added it.
|
@mohitjaggi I think some of them are fixed already and the changes are too big without some descriptions to follow. Wouldn't this be ensible if you close this and maybe submit a PR with smaller one? Or rebase this if you are working on this? |
No description provided.