SEA Session Configuration Fix: Explicitly convert values to str
#620
+70
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This disparity was observed on running
test_ssp_passthrough
withuse_sea
asTrue
in #594.Currently, without explicit conversion of the values of the
session_configuration
tostr
, the case of some of the values may not be as expected in the response. Particularly, intest_ssp_passthrough
, we get the response as[ansi_mode, true]
instead of[ansi_mode, True]
. To align with the Thrift implementation (which also does this), we explicitly cast our values tostr
to ensure the same configuration structure is received by the Databricks deployment regardless of backend choice.How is this tested?
test_spp_passthrough
in Complete Fetch Phase (forINLINE
disposition andJSON_ARRAY
format) #594.Related Tickets & Documents
https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing