-
Notifications
You must be signed in to change notification settings - Fork 113
Implement ResultSet Abstraction (backend interfaces for fetch phase) #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+800
−487
Merged
Changes from all commits
Commits
Show all changes
344 commits
Select commit
Hold shift + click to select a range
8ea5cf4
ensure backend client returns a ResultSet type in backend tests
varun-edachali-dbx 3eba92a
formatting (black)
varun-edachali-dbx 6735fd5
fix: correct client tests
varun-edachali-dbx 12388e8
formatting (black)
varun-edachali-dbx 853e6c3
remove excess comments (nit)
varun-edachali-dbx 4f8b54c
Update CODEOWNERS (#562)
jprakash-db 12ee56f
Enhance Cursor close handling and context manager exception managemen…
madhav-db a5152d0
PECOBLR-86 improve logging on python driver (#556)
saishreeeee 2c2984e
Update github actions run conditions (#569)
jprakash-db 4979422
fix: thrift_backend->backend, ResultSet -> ThriftResultSet
varun-edachali-dbx 6361e85
fix: thrift_backend -> backend in e2e test_driver
varun-edachali-dbx 904c304
PySQL Connector split into connector and sqlalchemy (#444)
jprakash-db e5ac8c6
Removed CI CD for python3.8 (#490)
jprakash-db e06fd2f
Added CI CD upto python 3.12 (#491)
jprakash-db 7126f97
Merging changes from v3.7.1 release (#488)
jprakash-db b1245da
Bumped up to version 4.0.0 (#493)
jprakash-db b54b04a
Support Python 3.13 and update deps (#510)
dhirschfeld e1d7f71
Improve debugging + fix PR review template (#514)
samikshya-db 1c721e0
Forward porting all changes into 4.x.x. uptil v3.7.3 (#529)
jprakash-db f1fa67a
Updated the actions/cache version (#532)
jprakash-db 512d37c
Updated the CODEOWNERS (#531)
jprakash-db ff0ec64
Add version check for urllib3 in backoff calculation (#526)
shivam2680 c5900c9
Support multiple timestamp formats in non arrow flow (#533)
jprakash-db c86e99b
prepare release for v4.0.1 (#534)
shivam2680 bcd6f01
Relaxed bound for python-dateutil (#538)
jprakash-db ca51d1d
Bumped up the version for 4.0.2 (#539)
jprakash-db d403fcd
Added example for async execute query (#537)
jprakash-db 1b4154c
Added urllib3 version check (#547)
jprakash-db eac0433
Bump version to 4.0.3 (#549)
jprakash-db 1b0fc9b
decouple session class from existing Connection
varun-edachali-dbx b45871e
add open property to Connection to ensure maintenance of existing API
varun-edachali-dbx 561c351
update unit tests to address ThriftBackend through session instead of…
varun-edachali-dbx a3188ad
chore: move session specific tests from test_client to test_session
varun-edachali-dbx ff7abf6
formatting (black)
varun-edachali-dbx e7e2333
use connection open property instead of long chain through session
varun-edachali-dbx fd4fae6
trigger integration workflow
varun-edachali-dbx 677e66a
fix: ensure open attribute of Connection never fails
varun-edachali-dbx 4ec8703
introduce databricksClient interface and thrift backend implementation
varun-edachali-dbx 6ecb6bf
change names of ThriftBackend -> ThriftDatabricksClient in tests
varun-edachali-dbx fe2ce17
formatting: black + re-organise backend into new dir
varun-edachali-dbx 568b1f4
Update CODEOWNERS (#562)
jprakash-db ebbd150
remove un-necessary example change
varun-edachali-dbx aa8af45
[empty commit] trigger integration tests
varun-edachali-dbx e7be76b
introduce normalised sessionId and CommandId for (near) complete back…
varun-edachali-dbx 7461715
fix: Any is not defined
varun-edachali-dbx b295acd
fix: get_session_id_hex() is not defined
varun-edachali-dbx 8afc5d5
command_handle -> command_id in ExecuteResponse
varun-edachali-dbx b8f9146
fix: active op handle -> active command id in Cursor
varun-edachali-dbx 7c733ee
fixed (most) tests by accounting for normalised Session interface
varun-edachali-dbx 0917ea1
fix: convert command id to operationHandle in status_request
varun-edachali-dbx 3fd2a46
decouple session class from existing Connection
varun-edachali-dbx 03d3ae7
add open property to Connection to ensure maintenance of existing API
varun-edachali-dbx fb0fa46
use connection open property instead of long chain through session
varun-edachali-dbx e3770cd
trigger integration workflow
varun-edachali-dbx 3b8002f
fix: ensure open attribute of Connection never fails
varun-edachali-dbx f1a350a
fix: de-complicate earlier connection open logic
varun-edachali-dbx 98b0dc7
Revert "fix: de-complicate earlier connection open logic"
varun-edachali-dbx afee423
[empty commit] attempt to trigger ci e2e workflow
varun-edachali-dbx 2d24fdd
PECOBLR-86 improve logging on python driver (#556)
saishreeeee a5561e8
Revert "Merge remote-tracking branch 'upstream/sea-migration' into de…
varun-edachali-dbx 0d890a5
Reapply "Merge remote-tracking branch 'upstream/sea-migration' into d…
varun-edachali-dbx c2aa762
fix: separate session opening logic from instantiation
varun-edachali-dbx fe642da
chore: use get_handle() instead of private session attribute in client
varun-edachali-dbx 394333c
fix: remove accidentally removed assertions
varun-edachali-dbx ef07acd
generalise open session, fix session tests to consider positional args
varun-edachali-dbx 1ef46cf
formatting (black)
varun-edachali-dbx 76ca997
correct session logic after duplication during merge
varun-edachali-dbx afc6f8f
args -> kwargs in tests
varun-edachali-dbx f6660ba
delegate protocol version to SessionId
varun-edachali-dbx 9871a93
ids -> backend/types
varun-edachali-dbx 595d795
update open session with normalised SessionId
varun-edachali-dbx 10ee940
remove merge artifacts, account for result set
varun-edachali-dbx 3d75d6c
fix: import CommandId in client tests
varun-edachali-dbx b8e1bbd
expect session_id in protocol version getter
varun-edachali-dbx dac08f2
enforce ResultSet return in exec commands in backend client
varun-edachali-dbx 7b0cbed
abstract Command State away from Thrift specific types
varun-edachali-dbx 9267ef9
close_command return not used, replacing with None and logging resp
varun-edachali-dbx 5f00532
move py.typed to correct places (#403)
wyattscarpenter 59ed5ce
Upgrade mypy (#406)
wyattscarpenter c95951d
Do not retry failing requests with status code 401 (#408)
Hodnebo 335d918
[PECO-1715] Remove username/password (BasicAuth) auth option (#409)
jackyhu-db ee4f94c
[PECO-1751] Refactor CloudFetch downloader: handle files sequentially…
kravets-levko 1c8bb11
Fix CloudFetch retry policy to be compatible with all `urllib3` versi…
kravets-levko 9de280e
Disable SSL verification for CloudFetch links (#414)
kravets-levko 04b626a
Prepare relese 3.3.0 (#415)
kravets-levko 2a01173
Fix pandas 2.2.2 support (#416)
kfollesdal b1faa09
[PECO-1801] Make OAuth as the default authenticator if no authenticat…
jackyhu-db 270edcf
[PECO-1857] Use SSL options with HTTPS connection pool (#425)
kravets-levko 8523fd3
Prepare release v3.4.0 (#430)
kravets-levko 763f070
[PECO-1926] Create a non pyarrow flow to handle small results for the…
jprakash-db 1e0d9d5
[PECO-1961] On non-retryable error, ensure PySQL includes useful info…
shivam2680 890cdd7
Reformatted all the files using black (#448)
jprakash-db 9bdee1d
Prepare release v3.5.0 (#457)
jackyhu-db cdd7a19
[PECO-2051] Add custom auth headers into cloud fetch request (#460)
jackyhu-db fcc2da9
Prepare release 3.6.0 (#461)
jackyhu-db d354309
[ PECO - 1768 ] PySQL: adjust HTTP retry logic to align with Go and N…
jprakash-db d63544e
[ PECO-2065 ] Create the async execution flow for the PySQL Connector…
jprakash-db 5bbf223
Fix for check_types github action failing (#472)
jprakash-db 9c62b21
Remove upper caps on dependencies (#452)
arredond 7bb7ca6
Updated the doc to specify native parameters in PUT operation is not …
jprakash-db 438a080
Incorrect rows in inline fetch result (#479)
jprakash-db eb50411
Bumped up to version 3.7.0 (#482)
jprakash-db 2a5b9c7
PySQL Connector split into connector and sqlalchemy (#444)
jprakash-db d31aa59
Removed CI CD for python3.8 (#490)
jprakash-db 3e62c90
Added CI CD upto python 3.12 (#491)
jprakash-db f9a6b13
Merging changes from v3.7.1 release (#488)
jprakash-db a941575
Bumped up to version 4.0.0 (#493)
jprakash-db 032c276
Updated action's version (#455)
newwingbird d36889d
Support Python 3.13 and update deps (#510)
dhirschfeld 22e5ce4
Improve debugging + fix PR review template (#514)
samikshya-db 7772403
Forward porting all changes into 4.x.x. uptil v3.7.3 (#529)
jprakash-db 8b27150
Updated the actions/cache version (#532)
jprakash-db 398db45
Updated the CODEOWNERS (#531)
jprakash-db c962b63
Add version check for urllib3 in backoff calculation (#526)
shivam2680 c246872
[ES-1372353] make user_agent_header part of public API (#530)
shivam2680 326f338
Updates runner used to run DCO check to use databricks-protected-runn…
madhav-db 37e73a9
Support multiple timestamp formats in non arrow flow (#533)
jprakash-db 3d7123c
prepare release for v4.0.1 (#534)
shivam2680 132e1b7
Relaxed bound for python-dateutil (#538)
jprakash-db 46090c0
Bumped up the version for 4.0.2 (#539)
jprakash-db 28249c0
Added example for async execute query (#537)
jprakash-db 5ab0a2c
Added urllib3 version check (#547)
jprakash-db 6528cd1
Bump version to 4.0.3 (#549)
jprakash-db 8f7754b
Cleanup fields as they might be deprecated/removed/change in the futu…
vikrantpuppala f7d3865
Refactor decimal conversion in PyArrow tables to use direct casting (…
jayantsing-db 61cc398
[PECOBLR-361] convert column table to arrow if arrow present (#551)
shivam2680 554d011
decouple session class from existing Connection
varun-edachali-dbx 6f28297
add open property to Connection to ensure maintenance of existing API
varun-edachali-dbx 983ec03
update unit tests to address ThriftBackend through session instead of…
varun-edachali-dbx 6f3b5b7
chore: move session specific tests from test_client to test_session
varun-edachali-dbx 29a2840
formatting (black)
varun-edachali-dbx 0d28b69
use connection open property instead of long chain through session
varun-edachali-dbx 8cb8cdd
trigger integration workflow
varun-edachali-dbx 4495f9b
fix: ensure open attribute of Connection never fails
varun-edachali-dbx c744117
introduce databricksClient interface and thrift backend implementation
varun-edachali-dbx ef5a06b
change names of ThriftBackend -> ThriftDatabricksClient in tests
varun-edachali-dbx abbaaa5
fix: remove excess debug log
varun-edachali-dbx 33765cb
fix: replace thrift_backend with backend in result set param
varun-edachali-dbx 788d8c7
fix: replace module replacement with concrete mock instance in execut…
varun-edachali-dbx 4debbd3
formatting: black + re-organise backend into new dir
varun-edachali-dbx 0e6e215
fix: sql.thrift_backend -> sql.backend.thrift_backend in tests and ex…
varun-edachali-dbx 925394c
Update CODEOWNERS (#562)
jprakash-db 4ad6c8d
Enhance Cursor close handling and context manager exception managemen…
madhav-db 51369c8
PECOBLR-86 improve logging on python driver (#556)
saishreeeee 9541464
Update github actions run conditions (#569)
jprakash-db cbdd3d7
remove un-necessary example change
varun-edachali-dbx ca38e95
[empty commit] trigger integration tests
varun-edachali-dbx b40c0fd
fix: use backend in Cursor, not thrift_backend
varun-edachali-dbx 35ed462
fix: backend references in integration tests
varun-edachali-dbx 37f3af1
fix: thrift_backend -> backend in ResultSet reference in e2e test
varun-edachali-dbx 09c5e2f
introduce normalised sessionId and CommandId for (near) complete back…
varun-edachali-dbx 4ce6aab
fix: Any is not defined
varun-edachali-dbx 307f447
fix: get_session_id_hex() is not defined
varun-edachali-dbx 802d8dc
command_handle -> command_id in ExecuteResponse
varun-edachali-dbx 944d446
fix: active op handle -> active command id in Cursor
varun-edachali-dbx 6338083
fixed (most) tests by accounting for normalised Session interface
varun-edachali-dbx 3658a91
fix: convert command id to operationHandle in status_request
varun-edachali-dbx 8ef6ed6
decouple session class from existing Connection
varun-edachali-dbx 61300b2
add open property to Connection to ensure maintenance of existing API
varun-edachali-dbx 44e7d17
formatting (black)
varun-edachali-dbx d2035ea
use connection open property instead of long chain through session
varun-edachali-dbx 8b4451b
trigger integration workflow
varun-edachali-dbx d21d2c3
fix: ensure open attribute of Connection never fails
varun-edachali-dbx 21068a3
fix: de-complicate earlier connection open logic
varun-edachali-dbx 476e763
Revert "fix: de-complicate earlier connection open logic"
varun-edachali-dbx 1e1cf1e
[empty commit] attempt to trigger ci e2e workflow
varun-edachali-dbx b408c2c
PECOBLR-86 improve logging on python driver (#556)
saishreeeee 73649f2
Revert "Merge remote-tracking branch 'upstream/sea-migration' into de…
varun-edachali-dbx a61df99
Reapply "Merge remote-tracking branch 'upstream/sea-migration' into d…
varun-edachali-dbx e1a2c0e
fix: separate session opening logic from instantiation
varun-edachali-dbx 71ba9d5
chore: use get_handle() instead of private session attribute in client
varun-edachali-dbx 160ba9f
fix: remove accidentally removed assertions
varun-edachali-dbx 6b3436f
generalise open session, fix session tests to consider positional args
varun-edachali-dbx 30849dc
formatting (black)
varun-edachali-dbx 4d455bb
correct session logic after duplication during merge
varun-edachali-dbx 6fc0834
args -> kwargs in tests
varun-edachali-dbx d254e48
delegate protocol version to SessionId
varun-edachali-dbx 370627d
ids -> backend/types
varun-edachali-dbx ca1b57d
update open session with normalised SessionId
varun-edachali-dbx 6c120c0
Merging changes from v3.7.1 release (#488)
jprakash-db cdf6865
Support Python 3.13 and update deps (#510)
dhirschfeld 12ce717
Updated the actions/cache version (#532)
jprakash-db 1215fd8
Add version check for urllib3 in backoff calculation (#526)
shivam2680 dd083f6
Support multiple timestamp formats in non arrow flow (#533)
jprakash-db 8d30436
Added example for async execute query (#537)
jprakash-db 066aef9
Added urllib3 version check (#547)
jprakash-db 1ed3514
decouple session class from existing Connection
varun-edachali-dbx ca80f94
formatting (black)
varun-edachali-dbx 6027fb1
use connection open property instead of long chain through session
varun-edachali-dbx 7a2f9b5
trigger integration workflow
varun-edachali-dbx 39294e9
fix: ensure open attribute of Connection never fails
varun-edachali-dbx 709e910
Revert "fix: de-complicate earlier connection open logic"
varun-edachali-dbx 1ad0ace
[empty commit] attempt to trigger ci e2e workflow
varun-edachali-dbx 913da63
PECOBLR-86 improve logging on python driver (#556)
saishreeeee d8159e7
Revert "Merge remote-tracking branch 'upstream/sea-migration' into de…
varun-edachali-dbx 0b91183
Reapply "Merge remote-tracking branch 'upstream/sea-migration' into d…
varun-edachali-dbx ff78b5f
fix: separate session opening logic from instantiation
varun-edachali-dbx c1d53d2
Enhance Cursor close handling and context manager exception managemen…
madhav-db a5a8e51
PECOBLR-86 improve logging on python driver (#556)
saishreeeee f7be10c
New Complex type test table + Github Action changes (#575)
jprakash-db a888dd6
remove excess logs, assertions, instantiations
varun-edachali-dbx 29a2985
Merge remote-tracking branch 'origin/sea-migration' into backend-inte…
varun-edachali-dbx 9b9735e
formatting (black) + remove excess log (merge artifact)
varun-edachali-dbx 0a8226c
fix typing
varun-edachali-dbx 42263c4
remove un-necessary check
varun-edachali-dbx ac984e4
remove un-necessary replace call
varun-edachali-dbx 8da84e8
introduce __str__ methods for CommandId and SessionId
varun-edachali-dbx f4f27e3
Merge remote-tracking branch 'origin/backend-interface' into fetch-in…
varun-edachali-dbx 4e3ccce
correct some merge artifacts
varun-edachali-dbx 04eb8c1
replace match case with if else for compatibility with older python v…
varun-edachali-dbx ca425eb
correct TOperationState literal, remove un-necessary check
varun-edachali-dbx 7a47dd0
chore: remove duplicate def
varun-edachali-dbx 00d9aeb
correct typing
varun-edachali-dbx eecc67d
docstrings for DatabricksClient interface
varun-edachali-dbx 9800636
stronger typing of Cursor and ExecuteResponse
varun-edachali-dbx e07f56c
remove utility functions from backend interface, fix circular import
varun-edachali-dbx 73fb141
rename info to properties
varun-edachali-dbx d838653
newline for cleanliness
varun-edachali-dbx 6654f06
fix circular import
varun-edachali-dbx 89425f9
formatting (black)
varun-edachali-dbx 93e55e8
to_hex_id -> get_hex_id
varun-edachali-dbx 7689d75
better comment on protocol version getter
varun-edachali-dbx 1ec8c45
formatting (black)
varun-edachali-dbx 80b7bc3
Merge remote-tracking branch 'origin/backend-interface' into fetch-in…
varun-edachali-dbx 904efe7
stricter typing for cursor
varun-edachali-dbx c91bc37
correct typing
varun-edachali-dbx 7f6073d
Merge remote-tracking branch 'origin/sea-migration' into fetch-interface
varun-edachali-dbx 1dada97
correct tests and merge artifacts
varun-edachali-dbx 2603f37
remove accidentally modified workflow files
varun-edachali-dbx ad97cc4
chore: remove accidentally modified workflow files
varun-edachali-dbx d4ce10f
add back accidentally removed docstrings
varun-edachali-dbx 6297f7b
clean up docstrings
varun-edachali-dbx 536387b
log hex
varun-edachali-dbx 7a6237e
remove unnecessary _replace call
varun-edachali-dbx 9b6afd2
add __str__ for CommandId
varun-edachali-dbx d80a3e2
take TOpenSessionResp in get_protocol_version to maintain existing in…
varun-edachali-dbx 88996e0
active_op_handle -> active_mmand_id
varun-edachali-dbx 1bec8e9
ensure None returned for close_command
varun-edachali-dbx af166b9
account for ResultSet return in new pydocs
varun-edachali-dbx ac34732
pydoc for types
varun-edachali-dbx 7e730db
move common state to ResultSet aprent
varun-edachali-dbx dfb4cc3
stronger typing in resultSet behaviour
varun-edachali-dbx 6a9f0e2
remove redundant patch in test
varun-edachali-dbx 0b2e83f
add has_been_closed_server_side assertion
varun-edachali-dbx 1f0c81f
remove redundancies in tests
varun-edachali-dbx aa7207e
more robust close check
varun-edachali-dbx fde4634
use normalised state in e2e test
varun-edachali-dbx 54f2b93
simplify corrected test
varun-edachali-dbx db73ecf
add line gaps after multi-line pydocs for consistency
varun-edachali-dbx cf8a629
use normalised CommandState type in ExecuteResponse
varun-edachali-dbx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why changed to void/none? if you choose to return void, make sure the implementations throw appropriate errors for the calling code
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type is not used by any of the references, so I chose to convert it to a
None
return type.Any errors in the call will be raised by
make_request
. This structure is identical to the existingcancel_command
implementation (which returnsNone
as well).