Skip to content

Cleanup fields as they might be deprecated/removed/change in the future #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025

Conversation

vikrantpuppala
Copy link
Contributor

@vikrantpuppala vikrantpuppala commented May 8, 2025

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

  • Certain fields are removed as they might be deprecated/removed/change in the future
  • Added new server protocol version SPARK_CLI_SERVICE_PROTOCOL_V9
  • Tested using e2e and unit tests

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

Copy link

github-actions bot commented May 8, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

github-actions bot commented May 8, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Vikrant Puppala <[email protected]>
Signed-off-by: Vikrant Puppala <[email protected]>
Signed-off-by: Vikrant Puppala <[email protected]>
Signed-off-by: Vikrant Puppala <[email protected]>
@jackyhu-db
Copy link
Collaborator

can you add more description in the PR to explain why you do this change and what change has been made?

@vikrantpuppala vikrantpuppala changed the title Clean thrift file Cleanup fields as they might be deprecated/removed/change in the future May 9, 2025
@vikrantpuppala vikrantpuppala merged commit bdb5154 into main May 9, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants