Skip to content

Don't hide error in WorkspaceApi.import_workspace_dir #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pietern merged 2 commits into from
Oct 24, 2022
Merged

Don't hide error in WorkspaceApi.import_workspace_dir #573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352313f
Don't hide error in WorkspaceApi.import_workspace_dir
pietern Oct 24, 2022
dbd658e
Fix lint
pietern Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions databricks_cli/workspace/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
from base64 import b64encode, b64decode

import click
from requests.exceptions import HTTPError

from databricks_cli.dbfs.exceptions import LocalFileExistsException
from databricks_cli.sdk import WorkspaceService
Expand Down Expand Up @@ -140,11 +139,7 @@ def import_workspace_dir(self, source_path, target_path, overwrite, exclude_hidd
if exclude_hidden_files:
# for now, just exclude hidden files or directories based on starting '.'
filenames = [f for f in filenames if not f.startswith('.')]
try:
self.mkdirs(target_path, headers=headers)
except HTTPError as e:
click.echo(e.response.json())
return
self.mkdirs(target_path, headers=headers)
for filename in filenames:
cur_src = os.path.join(source_path, filename)
# don't use os.path.join here since it will set \ on Windows
Expand Down