Skip to content

Conversation

@adamcain-db
Copy link
Contributor

  • Adds uc_api_version to ApiClient, defaulting it to 2.1.
  • Adds unity-catalog configure CLI with --version option, to allow user to configure a profile to use 2.0 as UC API version.
  • Unit tests for the above.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #496 (a02265f) into main (e6c10f9) will increase coverage by 1.71%.
The diff coverage is 80.48%.

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   61.10%   62.81%   +1.71%     
==========================================
  Files          55       56       +1     
  Lines        4664     4696      +32     
==========================================
+ Hits         2850     2950     +100     
+ Misses       1814     1746      -68     
Impacted Files Coverage Δ
databricks_cli/configure/config.py 88.23% <ø> (ø)
databricks_cli/unity_catalog/api.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/configure_cli.py 84.21% <84.21%> (ø)
databricks_cli/configure/cli.py 90.90% <100.00%> (+0.09%) ⬆️
databricks_cli/configure/provider.py 96.00% <100.00%> (+0.11%) ⬆️
databricks_cli/unity_catalog/uc_service.py 27.62% <100.00%> (+27.62%) ⬆️
databricks_cli/unity_catalog/utils.py 26.92% <0.00%> (+26.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c10f9...a02265f. Read the comment docs.

@adamcain-db adamcain-db force-pushed the SC-102227-add-uc-api-ver-2.1 branch from d5a4412 to a02265f Compare June 20, 2022 01:52
@adamcain-db
Copy link
Contributor Author

@pietern: could you review? (I am unable to add any reviewers to this PR, for some reason)

@adamcain-db
Copy link
Contributor Author

Based on discussion with @pietern, opened PR #498 with simpler (non-configurable) approach. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants