Skip to content

refactor(query): pass timezone by reference to avoid Arc churn #18998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

refactor(query): pass timezone by reference to avoid Arc churn #18998

merged 1 commit into from
Nov 20, 2025

Conversation

@TCeason
Copy link
Collaborator

@TCeason TCeason commented Nov 20, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

img_v3_02s7_7c669ca6-a181-4fbd-9bf9-786b96f6793g

  • Refactor the timezone plumbing so DateConverter, timestamp arithmetic helpers, JSON/date formatting, and all scalar/window consumers accept &TimeZone; cloning happens only when a jiff API needs ownership. This removes dozens of redundant Arc bumps and keeps behavior identical.
  • Update every downstream caller (functions, formats, window transforms, system/cloud history tables) to pass references, fixing the prior mismatches and addressing the jiff range clamp sites.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason
refactor(query): pass timezone by reference to avoid Arc churn
e677fa2 
  - Refactor the timezone plumbing so DateConverter, timestamp arithmetic helpers, JSON/date formatting, and all scalar/window consumers accept &TimeZone; cloning happens only when a jiff API needs ownership. This removes dozens of
    redundant Arc bumps and keeps behavior identical.
  - Update every downstream caller (functions, formats, window transforms, system/cloud history tables) to pass references, fixing the prior mismatches and addressing the jiff range clamp sites.
@TCeason TCeason marked this pull request as draft November 20, 2025 09:45
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 20, 2025
@TCeason TCeason marked this pull request as ready for review November 20, 2025 11:18
@BohuTANG BohuTANG merged commit 234ca84 into databendlabs:main Nov 20, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TCeason @zhang2014 @BohuTANG