refactor(meta): adopt external crate for shared state machine logic #17609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
changed the title
databendlabs/watcher crate for shared state machine logic
…achine logic This commit replaces the internal map API implementation with the external crate `databendlabs/map-api`. ### Context: In the future, the meta-service codebase will be shared across two main products: 1. A Raft-based meta-service. 2. An S3-based meta-service. The state machine logic for these services is largely identical and should be effectively shared to maximize code reuse and maintainability. Using the `databendlabs/map-api` crate facilitates this shared implementation.
drmingdrmer
force-pushed
the
203-external-crates
branch
from
d0be347 to
73efe6a
Compare
loloxwg
pushed a commit
to loloxwg/databend
that referenced
this pull request
Apr 3, 2025
…atabendlabs#17609) * refactor(meta): adopt `databendlabs/map-api` crate for shared state machine logic This commit replaces the internal map API implementation with the external crate `databendlabs/map-api`. ### Context: In the future, the meta-service codebase will be shared across two main products: 1. A Raft-based meta-service. 2. An S3-based meta-service. The state machine logic for these services is largely identical and should be effectively shared to maximize code reuse and maintainability. Using the `databendlabs/map-api` crate facilitates this shared implementation. * refactor(meta): adopt `databendlabs/watcher` crate for shared state machine logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(meta): adopt
databendlabs/watchercrate for shared state machine logicrefactor(meta): adopt
databendlabs/map-apicrate for shared state machine logicThis commit replaces the internal map API implementation with the
external crate
databendlabs/map-api.Context:
In the future, the meta-service codebase will be shared across two main
products:
The state machine logic for these services is largely identical and
should be effectively shared to maximize code reuse and maintainability.
Using the
databendlabs/map-apicrate facilitates this sharedimplementation.
Tests
Type of change
Related Issues
This change is