Skip to content

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Nov 15, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Add two new settings:

  • flight_connection_max_retry_times: Flight connection maximum retry times. The default value is 3 and the maximum value is 10. Set 0 to disable retry.
  • flight_connection_retry_interval: Flight connection retry interval. The default value is 3 seconds and the maximum value is 30 seconds.

The code is copied from PR #16234, thanks @dqhl76

fixes: #16771

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from sundy-li November 15, 2024 08:37
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 15, 2024
@Xuanwo Xuanwo requested a review from Copilot November 16, 2024 12:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (8)
  • src/query/storages/fuse/src/operations/mutation/mutator/recluster_mutator.rs: Evaluated as low risk
  • src/common/exception/src/context.rs: Evaluated as low risk
  • src/query/storages/orc/src/hashable_schema.rs: Evaluated as low risk
  • src/query/storages/parquet/src/parquet_rs/schema.rs: Evaluated as low risk
  • src/query/storages/parquet/src/parquet_rs/parquet_reader/row_group.rs: Evaluated as low risk
  • src/query/storages/orc/src/table.rs: Evaluated as low risk
  • src/common/exception/tests/it/exception_flight.rs: Evaluated as low risk
  • src/common/grpc/src/dns_resolver.rs: Evaluated as low risk

@b41sh b41sh changed the title feat(query): Support query_max_failures setting feat(query): Support flight_connection_max_retry_times and flight_connection_retry_interval setting Dec 5, 2024
@b41sh b41sh requested a review from zhang2014 December 5, 2024 09:09
@b41sh b41sh marked this pull request as ready for review December 5, 2024 09:10
@b41sh b41sh added this pull request to the merge queue Dec 6, 2024
Merged via the queue into databendlabs:main with commit 73cf386 Dec 6, 2024
81 of 82 checks passed
@b41sh b41sh deleted the feat-retry branch December 6, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query_max_failures settings to retry the query
3 participants