refactor: MetaGrpcClient needs to specify timeout to auto-reconnect to restarted server #16733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
…o restarted server Before c44ea20, MetaGrpcClient just auto reconnect if the target meta-service server is restarted. After c44ea20, the client behavior changed, if no timeout is set, the client reconnect to the restarted server but it hangs forever. In this commit, in the test: test_kv_api_restart_cluster_token_expired, give the client a fixed timeout to survive a server restart. - Fix: databendlabs#16704 (comment)
drmingdrmer
force-pushed
the
163-fix-client-survive-closed-server
branch
from
a7e250f to
4246e15
Compare
everpcpc
approved these changes
Oct 30, 2024
|
Really good fix. Thank you @drmingdrmer for helping addressing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: MetaGrpcClient needs to specify timeout to auto-reconnect to restarted server
Before c44ea20, MetaGrpcClient just
auto reconnect if the target meta-service server is restarted.
After c44ea20, the client behavior
changed, if no timeout is set, the client reconnect to the restarted
server but it hangs forever.
In this commit, in the test: test_kv_api_restart_cluster_token_expired,
give the client a fixed timeout to survive a server restart.
Tests
Type of change
Related Issues
This change is