Deep clone values in condition to prevent reference issues #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new version (fix) will be released: v3.17.2 [DataDrivenFormsBot] |
rvsia
force-pushed
the
cloneValuesInCondition
branch
from
c6e8782 to
0a65339
Compare
Codecov Report
@@ Coverage Diff @@
## master #1231 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 209 209
Lines 3612 3612
Branches 1261 1261
=======================================
Hits 3434 3434
Misses 178 178
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
rvsia
force-pushed
the
cloneValuesInCondition
branch
from
0a65339 to
8d5514c
Compare
Hyperkid123
approved these changes
Apr 11, 2022
|
🎉 This PR is included in version 3.17.2 🎉 The release is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1227
Description
Nested values were not correctly cloned so react.memo was receiving the updated values all the time and never updated the condition result.