-
Notifications
You must be signed in to change notification settings - Fork 92
Closed
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersreleasedrendererReact form renderer PRReact form renderer PR
Description
Scope: Form renderer
FormTemplate and onSubmit seem to be optional in version 3.17.0(see propTypes) but when checking the types for typescript it is still a required prop.
export interface FormRendererProps extends FormProps {
initialValues?: object;
onCancel?: (values: AnyObject, ...args: any[]) => void;
onReset?: () => void;
onError?: (...args: any[]) => void;
schema: Schema;
clearOnUnmount?: boolean;
clearedValue?: any;
componentMapper: ComponentMapper;
FormTemplate: ComponentType<FormTemplateRenderProps> | FunctionComponent<FormTemplateRenderProps>;
validatorMapper?: ValidatorMapper;
actionMapper?: ActionMapper;
schemaValidatorMapper?: SchemaValidatorMapper;
FormTemplateProps?: AnyObject;
children?: ReactNode | ((props: FormTemplateRenderProps) => ReactNode)
}
FormRenderer.propTypes = {
children: PropTypes.oneOfType([PropTypes.func, PropTypes.element]),
onSubmit: PropTypes.func,
onCancel: PropTypes.func,
onReset: PropTypes.func,
onError: PropTypes.func,
schema: PropTypes.object.isRequired,
clearOnUnmount: PropTypes.bool,
subscription: PropTypes.shape({ [PropTypes.string]: PropTypes.bool }),
clearedValue: PropTypes.any,
componentMapper: PropTypes.shape({
[PropTypes.string]: PropTypes.oneOfType([PropTypes.node, PropTypes.element, PropTypes.func, PropTypes.elementType]),
}).isRequired,
FormTemplate: PropTypes.elementType,
FormTemplateProps: PropTypes.object,
validatorMapper: PropTypes.shape({
[PropTypes.string]: PropTypes.func,
}),
actionMapper: PropTypes.shape({
[PropTypes.string]: PropTypes.func,
}),
schemaValidatorMapper: PropTypes.shape({
components: PropTypes.shape({
[PropTypes.string]: PropTypes.func,
}),
validators: PropTypes.shape({
[PropTypes.string]: PropTypes.func,
}),
actions: PropTypes.shape({
[PropTypes.string]: PropTypes.func,
}),
}),
initialValues: PropTypes.object,
decorators: PropTypes.array,
mutators: PropTypes.object,
};
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersreleasedrendererReact form renderer PRReact form renderer PR