Skip to content

Change the type annotation for __array_namespace__ to Any #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

Change the type annotation for __array_namespace__ to Any #357

merged 1 commit into from
Jan 5, 2022

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Jan 3, 2022

@rgommers rgommers added the topic: Static Typing Static typing. label Jan 3, 2022
BvB93
BvB93 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kgryte
kgryte approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit 85b5499 into data-apis:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

+1 more reviewer

@BvB93 BvB93 BvB93 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: Static Typing Static typing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgommers @kgryte @BvB93