Skip to content

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Sep 13, 2021

This PR

  • resolves gh-197.
  • clarifies full and full_like behavior when the fill_value exceeds the precision of the default integer/floating-point data type. Notably, this PR specifies that behavior is left unspecified and, thus, implementation-defined. (see also comment)

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers rgommers merged commit 7499649 into main Sep 15, 2021
@rgommers rgommers deleted the full-overflow branch September 15, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined behavior for overflowing .full()
2 participants