symmetric_matrices: draw from finite if necessary #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running
array_api_tests/meta/test_hypothesis_helpers.py::test_symmetric_matrices
produces a warning:The reason is that this test passes a boolean hypothesis parameter to the
symmetric_matrices
utility, and we mustdraw
that parameter before using it. Other tests pass a raw boolean value to the function, so a reasonable fix is to onlydraw
the value if it's not already abool
instance.With the change in this PR, the test no longer leads to a warning.