-
Notifications
You must be signed in to change notification settings - Fork 84
Add initial support for build_runner serve #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import 'package:args/command_runner.dart'; | ||
|
||
/// Extend to get a command with the arguments common to all build_runner | ||
/// commands. | ||
abstract class BuildRunnerCommandBase extends Command { | ||
BuildRunnerCommandBase() { | ||
// TODO(nshahan) Expose more common args passed to build_runner commands. | ||
// build_runner might expose args for use in wrapping scripts like this one. | ||
argParser | ||
..addOption('output', | ||
abbr: 'o', help: 'A directory to write the result of a build to.') | ||
..addFlag('verbose', | ||
abbr: 'v', | ||
defaultsTo: false, | ||
negatable: false, | ||
help: 'Enables verbose logging.'); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import 'dart:async'; | ||
|
||
import 'package:io/io.dart'; | ||
|
||
import 'build_runner_command_base.dart'; | ||
|
||
/// Command to execute pub run build_runner serve. | ||
class ServeCommand extends BuildRunnerCommandBase { | ||
@override | ||
final name = 'serve'; | ||
|
||
@override | ||
final description = 'Run a local web development server and a file system' | ||
' watcher that re-builds on changes.'; | ||
|
||
ServeCommand() { | ||
// TODO(nshahan) Expose more args passed to build_runner serve. | ||
// build_runner might expose args for use in wrapping scripts like this one. | ||
argParser | ||
..addOption('hostname', | ||
defaultsTo: 'localhost', help: 'Specify the hostname to serve on.'); | ||
} | ||
|
||
@override | ||
Future run() async { | ||
final manager = new ProcessManager(); | ||
final executable = 'pub'; | ||
final arguments = ['run', 'build_runner', 'serve', '--assume-tty']; | ||
arguments.addAll(argResults.arguments); | ||
var spawn = await manager.spawn(executable, arguments); | ||
|
||
await spawn.exitCode; | ||
await sharedStdIn.terminate(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,15 @@ | ||
import 'package:args/command_runner.dart'; | ||
|
||
import 'command/build_command.dart'; | ||
import 'command/serve_command.dart'; | ||
|
||
/// All available top level commands. | ||
CommandRunner webdevCommandRunner() { | ||
final commandRunner = | ||
new CommandRunner('webdev', 'A tool to develop Dart web projects.'); | ||
|
||
commandRunner.addCommand(new BuildCommand()); | ||
commandRunner.addCommand(new ServeCommand()); | ||
|
||
return commandRunner; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor nit:
I prefer cascades here:
I think this scales up better when we have 5 or 6 commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, done.