support basic scope in evaluate calls #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Apr 26, 2019
| @@ -246,51 +246,89 @@ require("dart_sdk").developer.invokeExtension( | |||
| @override | |||
| Future evaluate(String isolateId, String targetId, String expression, | |||
| {Map<String, String> scope, bool disableBreakpoints}) async { | |||
| scope ??= {}; | |||
There was a problem hiding this comment.
nit: why not use named parameters instead of ??=
With future non-nullability named parameters will be just as good.
There was a problem hiding this comment.
Once we have non-nullability, sure. Until then named parameter defaults should never be used imo.
jacob314
reviewed
Apr 26, 2019
jacob314
approved these changes
Apr 26, 2019
grouma
reviewed
Apr 26, 2019
grouma
approved these changes
Apr 26, 2019
jacob314
reviewed
Apr 26, 2019
| var arguments = scope.values.map((id) => {'objectId': id}).toList(); | ||
| var evalExpression = ''' | ||
| function($argsString) { | ||
| ${_getLibrarySnippet(library.uri)}; |
There was a problem hiding this comment.
add a TODO that we should cache the results of calling _getLibrarySnippet
and inject the library instance captured as another argument to the function. At that point it would make sense to unify the if and else cases here as they will have the same struture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of some exceptions in devtools when selecting widgets.
Next up is implementing
getObjectfor dart instances so that hovering over things works.