Skip to content

Remove unused deps and rev build_daemon version #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 26, 2019
Merged

Remove unused deps and rev build_daemon version #343

merged 5 commits into from
Apr 26, 2019

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Apr 26, 2019

No description provided.

@kevmoo kevmoo requested review from jakemac53 and grouma April 26, 2019 00:31
@kevmoo
Copy link
Member Author

kevmoo commented Apr 26, 2019

Oops!

@kevmoo
Copy link
Member Author

kevmoo commented Apr 26, 2019

Feel free to rebase and merge and delete the branch if you're happy

@kevmoo
Copy link
Member Author

kevmoo commented Apr 26, 2019

'twas keeping us from getting the last build deps

@jakemac53
Copy link
Contributor

I think @grouma was going to update the build_daemon version already, going to leave this up to him as he has more context.

Please rename the PR though now that it doesn't accurately describe the change.

@kevmoo
Copy link
Member Author

kevmoo commented Apr 26, 2019

I think @grouma was going to update the build_daemon version already, going to leave this up to him as he has more context.

Please rename the PR though now that it doesn't accurately describe the change.

Interesting story: by dropping the dep, it breaks things in such a way that I HAD to bump duild_daemon.

So I can wait for @grouma here – whatever he likes

@grouma
Copy link
Member

grouma commented Apr 26, 2019

LGTM. Prepped it for release.

@grouma grouma mentioned this pull request Apr 26, 2019
Closed
@grouma grouma changed the title Drop unused dep on pkg:built_value_generator Remove unused deps and rev build_daemon version Apr 26, 2019
@grouma grouma merged commit 301c61b into master Apr 26, 2019
@grouma grouma deleted the deps branch April 26, 2019 21:21
@jakemac53
Copy link
Contributor

built_value_generator is actually needed for codegen...

@kevmoo
Copy link
Member Author

kevmoo commented Apr 29, 2019

Wha? Oh crap...I didn't see a usage.

...but it's in the builder!

Ugh. Sorry!

Back to waiting on google/built_value.dart#639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grouma grouma grouma approved these changes

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevmoo @jakemac53 @grouma