Skip to content

Use correct ChromeDriver #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Use correct ChromeDriver #325

merged 3 commits into from
Apr 24, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Apr 24, 2019

ChromeDriver no longer supports a range of Chrome versions :(

Figure out the correct version of ChromeDriver to download and use that one.

Fix an issue where we were reusing the chrome profile from the Travis cache. Also add a timeout for waiting for the Chrome DevTools connection.

@grouma grouma requested a review from jakemac53 April 24, 2019 18:08
@grouma grouma merged commit 2d61960 into master Apr 24, 2019
@grouma grouma deleted the chromedriver branch April 24, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants