Fix launching Chrome on Windows #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Apr 24, 2019
|
|
||
| String get _executable { | ||
| if (Platform.environment.containsKey(_chromeEnvironment)) { | ||
| return Platform.environment[_chromeEnvironment]; | ||
| } | ||
| if (Platform.isLinux) return _linuxExecutable; | ||
| if (Platform.isMacOS) return _macOSExecutable; | ||
| if (Platform.isWindows) return _windowsExecutable; | ||
| if (Platform.isWindows) { | ||
| return p.join( |
There was a problem hiding this comment.
We should probably support absolute paths also like package:test does https://github.com/dart-lang/test/blob/ac21330338e0a7ad68fb19058bb92260706dd6cf/pkgs/test/lib/src/runner/executable_settings.dart#L41
There was a problem hiding this comment.
We don't support configuration of the windows executable location so that code snippet doesn't make sense. If you want to override the Chrome location you use the ChromeEnvironment variable.
|
cc @kenzieschmoll for fyi |
|
I had to rebuild the application due to the version change. This also caused some generated files to change but I figure it makes sense to include those. PTAL. |
jakemac53
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #320