Skip to content

Fix launching Chrome on Windows #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Fix launching Chrome on Windows #324

merged 3 commits into from
Apr 24, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Apr 24, 2019

Closes #320

@grouma grouma requested a review from jakemac53 April 24, 2019 16:14

String get _executable {
if (Platform.environment.containsKey(_chromeEnvironment)) {
return Platform.environment[_chromeEnvironment];
}
if (Platform.isLinux) return _linuxExecutable;
if (Platform.isMacOS) return _macOSExecutable;
if (Platform.isWindows) return _windowsExecutable;
if (Platform.isWindows) {
return p.join(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support configuration of the windows executable location so that code snippet doesn't make sense. If you want to override the Chrome location you use the ChromeEnvironment variable.

@jakemac53
Copy link
Contributor

cc @kenzieschmoll for fyi

@grouma
Copy link
Member Author

grouma commented Apr 24, 2019

I had to rebuild the application due to the version change. This also caused some generated files to change but I figure it makes sense to include those. PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daemon fails to launch Chrome on Windows
2 participants