Added method findPackageConfigFilePath to find the package_config.json file

[jyameo]

Added a method that returns the absolute file path of the package_config.json file in the .dart_tool directory, by searching recursively from the current directory hierarchy to ensure packageConfigPath is initialized in LoadStrategy at construction.

Fixes #2575

[srujzs]

Thanks for taking this on Jessy!

[srujzs]

I think we should instead provide this as an optional named parameter (optional named to avoid a breaking change) to each of the FrontendServerStrategyProviders e.g.:

webdev/dwds/lib/src/loaders/frontend_server_strategy_provider.dart

Line 156 in 616da45

FrontendServerDdcLibraryBundleStrategyProvider(

and avoid computing this in DWDS.

Flutter already calculates this, so we'd end up calculating it again. Flutter may also choose to configure the locations differently in tests for example.

I'd then imagine webdev calculating this separately and passing it to the provider (I guess in its case it'd use the BuildRunnerRequireStrategyProvider, which should also be updated in this PR).

[jyameo]

I thought about this approach and it makes sense to update each of the providers to allow passing a _packageConfigPath. It works for the flutter tools case since the info is already computed, we can simply pass it to the provider. However, for Webdev we don't have this details so what about we allow setting the value of _packageConfigPath for all the providers but in case we don't pass this value explicitly, we can compute it with _findPackageConfigFilePath. That way we can ensure that we always have this value set in all cases. Wdyt?

[srujzs]

My original thought was maybe webdev should calculate it separately and then pass it to DWDS, but maybe it doesn't matter. I do like the idea of our default being a bit more robust for the case of monorepos, so I think your plan makes sense.

[jyameo]

I added a similar method in Webdev to find the package config path and pass to DWDS and I also kept the default method in the load strategy class in case the value is not being passed.

[jyameo]

@srujzs I'm not too familiar with the release process but It looks like I need to update webdev.pubspec.yaml as well as it's currently pointing to 24.2.0? Do I need to release a new version of DWDS first before I can push my changes to Webdev?

[srujzs]

I'd avoid making changes to webdev in this PR as it relies on DWDS and I remember the bots having trouble publishing both versions at once.

I'd do the following if you want to publish webdev with a new version of dwds:

• Undo your webdev changes in this PR.
• Change the pubspec, changelog, and version.dart to use 24.3.5 instead of 24.3.5-wip as you're releasing a new version of DWDS.
• Once landed, you can go to checks and check the publish section e.g. https://github.com/dart-lang/webdev/actions/runs/13164273124. There should be a tag in the Publish tag (post-merge) section. Once you click on it and publish a new tag, the new version is published to pub.
• After you publish the new version of DWDS, I'd upload your changes to webdev, including updating the webdev version and updating its dependencies to use your new version of DWDS.

[jyameo]

I'd avoid making changes to webdev in this PR as it relies on DWDS and I remember the bots having trouble publishing both versions at once.

I'd do the following if you want to publish webdev with a new version of dwds:

• Undo your webdev changes in this PR.
• Change the pubspec, changelog, and version.dart to use 24.3.5 instead of 24.3.5-wip as you're releasing a new version of DWDS.
• Once landed, you can go to checks and check the publish section e.g. https://github.com/dart-lang/webdev/actions/runs/13164273124. There should be a tag in the Publish tag (post-merge) section. Once you click on it and publish a new tag, the new version is published to pub.
• After you publish the new version of DWDS, I'd upload your changes to webdev, including updating the webdev version and updating its dependencies to use your new version of DWDS.

Thanks for the clarification! That makes sense. I'll undo the webdev changes in this PR and update DWDS to 24.3.5 instead of 24.3.5-wip.

I believe we also need to update the DWDS version in flutter_tools. Is there anything different I need to keep in mind when updating the DWDS version there?

Appreciate the guidance! Let me know if there's anything else I should keep in mind.

[srujzs]

LGTM! Sorry for the delay, was OOO. :)

I believe we also need to update the DWDS version in flutter_tools. Is there anything different I need to keep in mind when updating the DWDS version there?

Indeed, we update packages in flutter by running the following script:

flutter update-packages --cherry-pick-package=dwds --cherry-pick-version=24.3.5

Since Flutter pins versions globally, this script goes through all the dependencies and updates their versions. The cherry-pick arguments tell it to only update DWDS. We should see the update in only one place (flutter_tools).