Updated logs #230
Merged
Updated logs #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Mar 22, 2019
webdev/lib/src/serve/utils.dart
Outdated
| stdout.writeln(''); | ||
| } | ||
| } | ||
|
|
||
| void Function(Level level, String message) logHandler = colorLog; |
There was a problem hiding this comment.
This isn't very discoverable - especially buried at the end of the serve/utils file :D.
If we are going with a global like this I would move it to a lib/src/logging.dart file so that its a bit easier to find, and document it clearly.
I would also consider a Zone variable, which at least removes some of the limitations of general global variables.
There was a problem hiding this comment.
Moved logging logic to logging.dart. Given that this logging logic is only used by the serve command I don't think we really need a zone. If it gets more complicated in the future, which I don't anticipate, we can revisit.
jakemac53
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logHandlerthroughoutDevWorkflowsimply make it globally available.logHandlerin theDaemoncommand.DevHandler.webdev serveCloses #219
Closes #220