Skip to content

Provide an app entrypoint to DWDS #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 30, 2023
Merged

Provide an app entrypoint to DWDS #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
468cc36
Add appEntrypoint to LoadStrategy
elliette Mar 22, 2023
8b5596b
Pass appEntrypoint to library helper
elliette Mar 22, 2023
701fbd9
Fix analyzer warnings
elliette Mar 22, 2023
26edfb8
Open correct entrypoint file
elliette Mar 22, 2023
3e9f074
Run dart fix
elliette Mar 22, 2023
19bd9d9
Small fix
elliette Mar 23, 2023
0a436c0
Update webdev
elliette Mar 23, 2023
5907b0c
Merge branch 'master' into app-entrypoint
elliette Mar 23, 2023
faafa33
Clean up
elliette Mar 23, 2023
ba2ce18
Add a test case
elliette Mar 23, 2023
96ebb9d
More cleanup
elliette Mar 23, 2023
dfa6a4d
Respond to PR comments
elliette Mar 27, 2023
4951056
More cleanup
elliette Mar 27, 2023
2912fac
Merge branch 'master' into app-entrypoint
elliette Mar 28, 2023
d0e8ebb
Respond to PR comments
elliette Mar 28, 2023
4d4f2af
Resolve merge conflicts
elliette Mar 30, 2023
cb2b91b
Update CHANGELOG and pubspec to indicate this is a breaking change
elliette Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## 18.0.3-dev
## 19.0.0-dev
- Allow clients to specify the connected app's entrypoint file. - [#2047](https://github.com/dart-lang/webdev/pull/2047)

## 18.0.2

Expand Down
11 changes: 9 additions & 2 deletions dwds/lib/src/debugging/libraries.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,15 @@ class LibraryHelper extends Domain {
// TODO: read entrypoint from app metadata.
// Issue: https://github.com/dart-lang/webdev/issues/1290
final libraries = await libraryRefs;
_rootLib = libraries
.firstWhereOrNull((lib) => lib.name?.contains('org-dartlang') ?? false);
if (globalLoadStrategy.appEntrypoint != null) {
_rootLib = libraries.firstWhereOrNull(
(lib) => Uri.parse(lib.uri ?? '') == globalLoadStrategy.appEntrypoint,
);
}
_rootLib = _rootLib ??
libraries.firstWhereOrNull(
(lib) => lib.name?.contains('org-dartlang') ?? false,
);
_rootLib = _rootLib ??
libraries
.firstWhereOrNull((lib) => lib.name?.contains('main') ?? false);
Expand Down
Loading