Skip to content

[MV3 Debug Extension] Print console messages on test failure #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

elliette
Copy link
Contributor

Uses printOnFailure to log the most recent messages logged to the service worker or chrome devtools console for debugging purposes.

Also fixes some test failures.

@elliette elliette changed the title [MV3 Debug Extension] [MV3 Debug Extension] Print console messages on test failure Feb 14, 2023
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit a761125 into dart-lang:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants