Skip to content

Pull out dart:io-dependent functions from/src/utilities/shared.dart into /src/utilities/server.dart #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 6, 2023

Pull out dart:io-dependent functions from/src/utilities/shared.dart into /src/utilities/server.dart

shared.dart is split into:

  • shared.dart: all utilities that don't need dart:io
  • server.dart: all utilities that do need dart:io

This is preparatory work for #1938

@elliette elliette requested a review from annagrin February 6, 2023 21:12
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit b399e94 into dart-lang:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants