Skip to content

Move batched_stream from /lib/src to /lib/shared #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 6, 2023

Move batched_stream.dart from lib/src to lib/shared, this way it can be used in both DWDS and the debug extension.

Before we had two copies of batched_stream:

  • in src/utilities for use in DWDS
  • in src/web_utilities for use in the debug extension

Closes dart-lang/sdk#49973
Preparatory work for #1938

@elliette elliette changed the title Move batched_stream to from lib/src to /lib/shared Move batched_stream from lib/src to /lib/shared Feb 6, 2023
@elliette elliette changed the title Move batched_stream from lib/src to /lib/shared Move batched_stream from /lib/src to /lib/shared Feb 6, 2023
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 6255c85 into dart-lang:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dart2js skips compilation if the same dart library is used by dart vm project
2 participants