Skip to content

Handle case where list.objectId is null in batched_expression_evaluator.dart #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Handle case where list.objectId is null in batched_expression_evaluator.dart #1930

merged 2 commits into from
Feb 1, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 1, 2023

Work towards flutter/flutter#119084

FYI @christopherfujino

@elliette elliette requested a review from annagrin February 1, 2023 00:22
annagrin
annagrin approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

christopherfujino
christopherfujino approved these changes Feb 1, 2023
View reviewed changes
Copy link

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette mentioned this pull request Feb 1, 2023
Merged
@elliette elliette merged commit e96644e into dart-lang:dwds-16.0.4-release Feb 1, 2023
@elliette elliette mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliette @christopherfujino @annagrin