Skip to content

Fix broken WebDev tests on Dart main #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jan 28, 2023

Work towards #1878

Fixes #1922

@elliette elliette changed the title Fix broken WebDev tests Fix broken WebDev tests on Dart main Jan 28, 2023
var exampleDirectory =
p.absolute(p.join(p.current, '..', 'fixtures', '_webdevSmoke'));
p.absolute(p.join(p.current, '..', 'fixtures', 'webdevSoundSmoke'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing underscore?
webdevSoundSmoke -> _webdevSoundSmoke

Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as adding the underscore to the name of the fixture gets the sound version of the test passing. 😄

@elliette
Copy link
Contributor Author

Closing in favor of #1920 (already submitted)

@elliette elliette closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webdev tests breakages on main Dart SDK branch
2 participants