Skip to content

[MV3 Dart Debug Extension] Fix authentication error #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 1, 2023
Merged

[MV3 Dart Debug Extension] Fix authentication error #1916

merged 14 commits into from
Feb 1, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jan 25, 2023 •
edited
Loading

See b/266957158 for details and explanation of fix.

@elliette elliette closed this Jan 25, 2023
@elliette elliette reopened this Jan 25, 2023
@annagrin annagrin mentioned this pull request Jan 27, 2023
Merged
@elliette elliette changed the title [DO NOT SUBMIT] Sending auth messages between extension and client Fix authentication error Jan 27, 2023
@elliette elliette changed the title Fix authentication error [MV3 Debug Extension] Fix authentication error Jan 27, 2023
@elliette elliette changed the title [MV3 Debug Extension] Fix authentication error [MV3 Dart Debug Extension] Fix authentication error Jan 27, 2023
@elliette elliette marked this pull request as ready for review January 27, 2023 23:24
@elliette elliette requested a review from annagrin January 27, 2023 23:30
annagrin
annagrin reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add new tests, or are there old ones covering this functionality?

@elliette
Copy link
Contributor Author

Do we need to add new tests, or are there old ones covering this functionality?

Ah good point! Added a test case, and it even caught a bug in the implementation!

annagrin
annagrin approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit a36f4e8 into dart-lang:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin