Skip to content

Split frontend_server_evaluate tests to avoid timeouts #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions dwds/test/frontend_server_evaluate_sound_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
@Timeout(Duration(minutes: 5))

import 'dart:io';

import 'package:test/test.dart';

import 'fixtures/context.dart';
import 'evaluate_common.dart';

void main() async {
// Enable verbose logging for debugging.
final debug = false;

for (var useDebuggerModuleNames in [false, true]) {
group('Debugger module names: $useDebuggerModuleNames |', () {
final nullSafety = NullSafety.sound;
group('${nullSafety.name} null safety |', () {
for (var indexBaseMode in IndexBaseMode.values) {
group('with ${indexBaseMode.name} |', () {
testAll(
compilationMode: CompilationMode.frontendServer,
indexBaseMode: indexBaseMode,
nullSafety: nullSafety,
useDebuggerModuleNames: useDebuggerModuleNames,
debug: debug,
);
},
// https://github.com/dart-lang/sdk/issues/49277
skip: indexBaseMode == IndexBaseMode.base && Platform.isWindows);
}
});
});
}
}
51 changes: 0 additions & 51 deletions dwds/test/frontend_server_evaluate_test.dart

This file was deleted.

39 changes: 39 additions & 0 deletions dwds/test/frontend_server_evaluate_weak_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
@Timeout(Duration(minutes: 5))

import 'dart:io';

import 'package:test/test.dart';

import 'fixtures/context.dart';
import 'evaluate_common.dart';

void main() async {
// Enable verbose logging for debugging.
final debug = false;

for (var useDebuggerModuleNames in [false, true]) {
group('Debugger module names: $useDebuggerModuleNames |', () {
final nullSafety = NullSafety.weak;
group('${nullSafety.name} null safety |', () {
for (var indexBaseMode in IndexBaseMode.values) {
group('with ${indexBaseMode.name} |', () {
testAll(
compilationMode: CompilationMode.frontendServer,
indexBaseMode: indexBaseMode,
nullSafety: nullSafety,
useDebuggerModuleNames: useDebuggerModuleNames,
debug: debug,
);
},
// https://github.com/dart-lang/sdk/issues/49277
skip: indexBaseMode == IndexBaseMode.base && Platform.isWindows);
}
});
});
}
}