Skip to content

[MV3 Debug Extension] Don't connect to DWDS if we already have a debugger attached #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jan 20, 2023

This PR checks whether or not we already have a debugger attached before trying to connect to DWDS.

With this change:

  • a warning notification is shown if a user tries to open Dart DevTools when they already have a debugger open
  • refreshing the dart app will not open a new DevTools instance

@elliette elliette changed the title [WIP] Don't connect to DWDS if we already have a DevTools instance Don't connect to DWDS if we already have a DevTools instance Feb 1, 2023
@elliette elliette changed the title Don't connect to DWDS if we already have a DevTools instance [MV3 Debug Extension] Don't connect to DWDS if we already have a debugger attached Feb 1, 2023
@elliette elliette marked this pull request as ready for review February 1, 2023 23:47
@elliette elliette requested a review from annagrin February 1, 2023 23:47
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit c453ebe into dart-lang:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants