Skip to content

Tests should servemain.dart and index.html from the same directory #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Dec 22, 2022

Work towards #1845

We have a few tests across DWDS that are serving an index.html and a main.dart file from different directories. This is confusing and was (I'm guessing) unintentional. This changes those tests so the files are being served from the same directory.

@elliette elliette changed the title [DO NOT SUBMIT] index.html and main.dart file should be in same directory Tests should servemain.dart and index.html from the same directory Dec 22, 2022
Copy link

@CoderDake CoderDake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about TestContext, but LGTM as long as all the tests are still running and working 😄

@elliette elliette merged commit 8795ca5 into dart-lang:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants