DebugSession listens to events instead of just sending events
#1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
approved these changes
Dec 1, 2022
| final tabUrl = await _getTabUrl(dartAppTabId); | ||
| // Send a DevtoolsRequest to the event stream: | ||
| final event = jsonEncode(serializers.serialize(DevToolsRequest((b) => b | ||
| debugSession.sendEvent<DevToolsRequest>(DevToolsRequest((b) => b |
There was a problem hiding this comment.
Nit: do you need to specify the type parameter here? I thought debugSession.sendEvent(DevToolsRequest... should work?
| @@ -208,7 +208,7 @@ void _forwardChromeDebuggerEventToDwds( | |||
| if (method == 'Debugger.scriptParsed') { | |||
| debugSession.sendBatchedEvent(event); | |||
| } else { | |||
| debugSession.sendEvent(event); | |||
| debugSession.sendEvent<ExtensionEvent>(event); | |||
There was a problem hiding this comment.
same here and in other places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor of the
DebugSession:ExtensionEvents