Updates the fixture package pubspecs so it is clear what shouldn't be migrated to null-safety
#1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
changed the title
fixture package pubspecs so it is clear what needs to be migrated to sound null-safetyfixture package pubspecs so it is clear what shouldn't be migrated to null-safety
annagrin
approved these changes
Nov 30, 2022
fixtures/_test/pubspec.yaml
Outdated
| @@ -1,7 +1,10 @@ | |||
| # This code is for testing that the debugger works with weak null-safety | |||
| # so we should not migrate it to null-safety. | |||
| # TODO(elliette): Once Dart 3.0 is released, delete this directory. | |||
There was a problem hiding this comment.
Technically we would need to keep them a bit longer until no code uses the weak mode.
There was a problem hiding this comment.
Updated the comment, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also runs the migration tool on
testCircular1SoundandtestCircular2Soundbecause it was complaining those weren't migrated.