Detect whether the Debug Extension was built for dev or release #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
changed the title
annagrin
approved these changes
Nov 29, 2022
| _newKeyValue( | ||
| oldLine: line, | ||
| newKey: 'name', | ||
| newValue: '[DEV] MV3 Dart Debug Extension', |
There was a problem hiding this comment.
Thanks! That is really helpful to distinguish them from each other!
| String msg, { | ||
| String? prefix, | ||
| bool devOnly = true, | ||
| }) { | ||
| _log(msg, prefix: prefix); |
There was a problem hiding this comment.
needs to pass devOnly to _log?
| String msg, { | ||
| String? prefix, | ||
| bool devOnly = true, | ||
| }) { | ||
| _log(msg, prefix: prefix, level: _LogLevel.warn); |
| debugError( | ||
| String msg, { | ||
| String? prefix, | ||
| bool devOnly = true, |
| _LogLevel? level, | ||
| String? prefix, | ||
| }) { | ||
| if (devOnly && !isDevMode()) return; |
There was a problem hiding this comment.
Would it be reasonable to rename devOnly to verbose and maybe flip the default to false?
There was a problem hiding this comment.
Sg, switched to verbose!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects whether the Debug Extension was built for dev or release.
In dev mode:
This PR also moves the
console.logimplementation intologgerand makes it private, so that the only way to log to the console is with thedebugLogutilities.