Connect to a chrome.runtime port to keep the service worker alive
#1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
approved these changes
Nov 15, 2022
| .firstWhere((url) => url.contains(chromeExtension)); | ||
| final urlSegments = p.split(extensionUrl); | ||
| final extensionId = urlSegments[urlSegments.indexOf(chromeExtension) + 1]; | ||
| return '$chromeExtension//$extensionId'; |
There was a problem hiding this comment.
I know that we are currently not running this on windows, but it would save us an additional break when we do:
can we use platform-independent directory separator, i.e: p.join('chromeExtension, extensionId)?
There was a problem hiding this comment.
Done! Using p.join wherever possible. In this case it's creating a non-standard Chrome extension URI (eg chrome-extension://abcdefg), not a file URI. I couldn't find a path utility method to support that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the workaround described in https://bugs.chromium.org/p/chromium/issues/detail?id=1152255#c21
Has the connected Dart app tab connect to a
chrome.runtimeport. The service worker listens for theonConnectevent, and starts a timer to reconnect after 5 minutes (the service worker lifetime).