Skip to content

Match server paths to source maps paths #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Aug 30, 2022

Make server paths match directory structure.

  • Add PackageUriMapper class that creates server paths from package paths
    • useDebuggerModuleNames parameter controls switching the mode between new and old behavior
  • Pass the mapper as a parameter to FrontendServerRequireStrategy
  • Update dart uris and dwds code
  • Update test infrastructure to match current flutter tools behavior
  • Pass use-debugger-module-names flag to the frontend server in new mode
  • Update existing frontend server tests to work with useDebuggerModuleNames enabled as well
  • Add new test projects and tests to verify new behavior

Closes: #1719
Helps: #1692

@annagrin annagrin requested a review from elliette August 31, 2022 16:05
@annagrin annagrin merged commit 7e03357 into dart-lang:master Aug 31, 2022
elliette added a commit to elliette/webdev that referenced this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DWDS] provide an API to map the package: paths to server paths to match the directory structure
2 participants