Skip to content

Migrate build_daemon_callstack_test and build_daemon_breakpoint_test to null-safety #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Aug 8, 2022

No description provided.

@elliette elliette requested a review from annagrin August 8, 2022 21:04
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments.

final bp = await service.addBreakpointWithScriptUri(
isolate.id, mainScript.uri, line);
isolate.id!, mainScript.uri!, line);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to define non-nullable isolateId and mainScriptUri as it seems like we are using them everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elliette elliette merged commit 8afdb97 into dart-lang:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants