Implement lookupResolvedPackageUris and lookupPackageUris #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement the new API from vm service 7.4.0 - add tests - does not suport dart: scheme uris yet: dart-lang#1457 Closes: dart-lang#1446
nshahan
reviewed
Dec 1, 2021
bkonyi
reviewed
Dec 13, 2021
natebosch
reviewed
Dec 16, 2021
nshahan
reviewed
Jan 10, 2022
| /// The way we resolve file: URLs into package: URLs | ||
| static PackageConfig _packageConfig; | ||
|
|
||
| /// The way we resolve dart: URLs into org-dartland-sdk: URLs |
Comment on lines
+1310
to
+1314
| containsAll([ | ||
| contains('/_test/example/hello_world/main.dart'), | ||
| contains('/lib/path.dart'), | ||
| contains('/lib/src/path_set.dart'), | ||
| ])); |
There was a problem hiding this comment.
I'm a little confused why expectation needs containsAll() with nested contains(). Is that on purpose?
There was a problem hiding this comment.
containsAll matches the array, and the nested contains match the elements. I like that our matches allow that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lookupResolvedPackageUris and lookupPackageUris do not handle uris with dart scheme #1457
Closes: #1446