Skip to content

Ignore unsafe html #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Ignore unsafe html #1396

merged 2 commits into from
Sep 1, 2021

Conversation

grouma
Copy link
Member

@grouma grouma commented Aug 31, 2021

We will soon turn on safe html validation for all third_party Dart code. Prepare for this by cleaning up DWDS issues.

@grouma grouma requested a review from annagrin August 31, 2021 19:04
@google-cla google-cla bot added the cla: yes label Aug 31, 2021
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The test errors are caused by a changed compilation error message in the newest compiler, will be fixed by #1397

@annagrin
Copy link
Contributor

@grouma FYI - the test break is fixed now.

@grouma grouma merged commit 5bd3dc6 into master Sep 1, 2021
@kevmoo kevmoo deleted the ignore-unsafe branch November 11, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants