Skip to content

Fix handling of files with spaces in frontend_server_client #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 16, 2021
Merged

Fix handling of files with spaces in frontend_server_client #1382

merged 9 commits into from
Aug 16, 2021

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Aug 16, 2021 •
edited
Loading

Fixes https://github.com/dart-lang/webdev/issues/1380

Also enables running of the tests on windows/linux.

@google-cla google-cla bot added the cla: yes label Aug 16, 2021
@jakemac53 jakemac53 requested a review from annagrin August 16, 2021 16:42
@jakemac53
Copy link
Contributor Author

This should hopefully fail on windows and I can start diagnosing things.

@jakemac53
Copy link
Contributor Author

Nice, this test repros on linux as well 👍. You only see it on windows in practice because spaces in file/directory names are pretty unique to windows.

@jakemac53 jakemac53 changed the title add test for file with spaces to frontend_server_client, run tests on CI on linux and windows Fix handling of files with spaces in frontend_server_client Aug 16, 2021
natebosch
natebosch approved these changes Aug 16, 2021
View reviewed changes
@jakemac53 jakemac53 merged commit 50fe70a into master Aug 16, 2021
@jakemac53 jakemac53 deleted the add-frontend-server-client-tests branch August 16, 2021 18:25
@jakemac53
Copy link
Contributor Author

cc @jonasfj @sigurdm You may want to add some tests in pub for this case as well? Just to ensure a similar issue doesn't crop up if the compilation strategy were to change in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

@annagrin annagrin Awaiting requested review from annagrin

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FrontendServerClient doesn't handle properly filepaths with spaces on windows, so webdev launch fails
2 participants
@jakemac53 @natebosch