Updated docs, added trivial tests #11
Conversation
webdev/pubspec.yaml
Outdated
|
|
||
| dev_dependencies: | ||
| test: ^0.12.0 | ||
| test_descriptor: ^1.0.0 |
There was a problem hiding this comment.
Where is test_descriptor used?
There was a problem hiding this comment.
Oh! Not yet...good catch...
| ;; | ||
| *) echo -e "\033[31mNot expecting TASK '${TASK}'. Error!\033[0m" | ||
| EXIT_CODE=1 | ||
| ;; |
There was a problem hiding this comment.
Is this our recommended approach to travis testing now? What happened to the days of just adding a few lines in the travis.yaml?
There was a problem hiding this comment.
This is using mono_repo – let's us test multiple packages in one repo easily...
|
PTAL |
|
|
||
| test('should fail in a package without a build_runner dependency', () async { | ||
| var process = await TestProcess.start('dart', ['bin/webdev.dart', 'serve']); | ||
| await process.shouldExit(255); |
There was a problem hiding this comment.
Are we expecting anything other than a failure yet?
There was a problem hiding this comment.
This is running against itself – so no build_runner dep or anything. We expect it to always fail.
...although in the future it should fail with a more helpful message and a different error code
| @@ -0,0 +1,39 @@ | |||
| // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | |||
|
Eh...
…On Tue, Mar 20, 2018 at 10:50 AM Nate Bosch ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In webdev/test/integration_test.dart
<#11 (comment)>:
> @@ -0,0 +1,39 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2018
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#11 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCivZeP_KnUgJc693c9WZR2D3TIMiLks5tgUFfgaJpZM4SyONG>
.
|
No description provided.