-
Notifications
You must be signed in to change notification settings - Fork 77
contribute a CI #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| import 'package:dash_analytics/src/utils.dart'; | ||
| import 'package:file/file.dart'; | ||
| import 'package:file/memory.dart'; | ||
| import 'package:test/test.dart'; | ||
| import 'package:yaml/yaml.dart'; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I had these import statements within my repo, it recognized that the imports for package:... were separate from package:dash_analytics/... but it seems that it treats them the same now and combines them into one block. I imagine this because of the new structure?
https://github.com/eliasyishak/dash_analytics/blob/main/test/dash_analytics_test.dart#L9-L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's odd - what were you using to sort the imports?
Here, I used the 'organize imports' command (from vs-code, via the analysis server). That will just treat all package: imports the same (sorting dart:, package:, then file imports, and breaking them into separate groups).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also used the same command via VS Code, but just adding here for clarity but it seems like the root folder for VS Code affects how it organizes imports within the test directory. When making root tools/ it doesn't recognize that package:... and 'package:dash_analytics/...is different. But when you make your roottools/pkgs/dash_analytics` it properly separates them.
Could have to do with how the analysis server is determining which directory is the source directory for a given package.
|
let me know if this looks good as is or you'd like the import order change reverted - |
eliasyishak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look more into the sorting issue later, but LGTM otherwise!
Uh oh!
There was an error while loading. Please reload this page.